nodeSolidServer / nodeSolidServer/node-solid-server
Updates-Via header in OPTIONS
Open
Nobody has claimed this yet.
test-case
- Dominant language
- JavaScript
- Stars
- 1.8k
- Forks
- 308
- PR merge metrics
- No merged PRs in 30d
Description
The Solid WebSocket API Specs say that Updates-Via header can be found in an OPTIONS request to the server.
I am not finding an Updates-Via header in OPTIONS for node solid server, though I do get one if I do an HTTP HEAD:
$ curl -k -i -X OPTIONS https://localhost:8443/public/
HTTP/1.1 204 No Content
X-Powered-By: solid-server/5.1.2
Vary: Accept, Authorization, Origin, Access-Control-Request-Headers
Access-Control-Allow-Credentials: true
Access-Control-Allow-Methods: OPTIONS,HEAD,GET,PATCH,POST,PUT,DELETE
Access-Control-Max-Age: 1728000
Access-Control-Expose-Headers: Authorization, User, Location, Link, Vary, Last-Modified, ETag, Accept-Patch, Accept-Post, Updates-Via, Allow, WAC-Allow, Content-Length, WWW-Authenticate
Allow: COPY,GET,HEAD,POST,PATCH,PUT,DELETE
Link: <https://localhost:8443/public/.well-known/solid>; rel="service", <https://localhost:8443>; rel="http://openid.net/specs/connect/1.0/issuer", <.acl>; rel="acl", <.meta>; rel="describedBy", <http://www.w3.org/ns/ldp#Container>; rel="type", <http://www.w3.org/ns/ldp#BasicContainer>; rel="type"
Accept-Patch: application/sparql-update
Accept-Post: */*
ETag: W/"23-dYHCBqdZ5e1V1nWlG0I6iB9SOvk"
Date: Wed, 05 Jun 2019 20:57:22 GMT
Connection: keep-alive
vs
$ curl -k --head https://localhost:8443/public/
HTTP/1.1 200 OK
X-Powered-By: solid-server/5.1.2
Vary: Accept, Authorization, Origin
Access-Control-Allow-Credentials: true
Access-Control-Expose-Headers: Authorization, User, Location, Link, Vary, Last-Modified, ETag, Accept-Patch, Accept-Post, Updates-Via, Allow, WAC-Allow, Content-Length, WWW-Authenticate
Allow: OPTIONS, HEAD, GET, PATCH, POST, PUT, DELETE
Link: <.acl>; rel="acl", <.meta>; rel="describedBy", <http://www.w3.org/ns/ldp#Container>; rel="type", <http://www.w3.org/ns/ldp#BasicContainer>; rel="type"
MS-Author-Via: SPARQL
Updates-Via: wss://localhost:8443
Content-Type: application/octet-stream; charset=utf-8
Content-Length: 2
ETag: W/"2-nOO9QiTIwXgNtWtBJezz8kv3SLc"
Date: Wed, 05 Jun 2019 20:57:00 GMT
Connection: keep-alive
This is using v5.1.2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the request handling for OPTIONS and HEAD responses and search for the Updates-Via header generation. Reproduce the discrepancy with the curl commands from the issue against the affected server version, then verify that the expected header behavior is consistent for both methods.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100