nodeSolidServer / nodeSolidServer/node-solid-server
Auth proxy doesn't follow redirects
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.8k
- Forks
- 308
- PR merge metrics
- No merged PRs in 30d
Description
Note PR https://github.com/solid/node-solid-server/pull/1070 discussing how some auth proxy tests failed (in the original PR). The following in PROXY_SETTINGS should still work for https://github.com/solid/node-solid-server/blob/master/lib/handlers/auth-proxy.js
followRedirects: true,
proxyTimeout: 5000
See also https://github.com/solid/node-solid-server/issues/1069
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with lib/handlers/auth-proxy.js and the PROXY_SETTINGS excerpt, then read the discussion in PR 1070 and issue 1069 for the failed auth proxy tests. Run the relevant auth proxy tests and verify that redirects are followed while the 5000 ms proxy timeout remains effective.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript, node.js
- Domain
- authentication, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100