Make lack of implict copy very clear. Add .copy() function.

Open
#14 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp
Domain
data

Research direction

Start at the main PlyData class and inspect how its current copy behavior is defined, along with any existing tests or examples covering PlyData usage. The work is complete when copying is explicitly disallowed by the class interface and an explicit .copy() operation provides the intended copy behavior, with tests covering both cases.

Written by the indexing model from the issue text.

Description

enhancement good first issue

Right now the main PlyData class cannot be implicitly copied. This is probably the right behavior; doing so is likely a mistake.

However, we can improve the situation in two ways

  • Explicitly delete the copy constructor, to make it clear that the behavior is intentional
  • Provide a .copy() function for the few situations where one really does want to explicitly copy
Dominant language
C++
Stars
406
Forks
74
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nmwsharp/happly

All issues in nmwsharp/happly

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.