SignpostIntrinsicTriangulation perhaps missing some function definitions?

Open
#83 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp

Research direction

Start by inspecting the declarations in signpost_intrinisc_triangulation.h and searching the repository for definitions of equivalentPointOnIntrinsic and equivalentPointOnInput. Reproduce the unresolved external linker errors with a use of SignpostIntrinsicTriangulation. Done means the functions are defined and the affected code links successfully.

Written by the indexing model from the issue text.

Description

It seems like the functions equivalentPointOnIntrinsic(const SurfacePoint& pointOnInput) and equivalentPointOnInput(const SurfacePoint& pointOnIntrinsic) may be declared but not defined for SignpostIntrinsicTriangulation? When I grep the master branch I seem to find their declarations in signpost_intrinisc_triangulation.h, but I can't seem to locate a definition. Obviously, my first clue was unresolved external link errors when I trie to use them. Just curious if their implementation might have existed at one time?

Dominant language
C++
Stars
1.3k
Forks
183
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nmwsharp/geometry-central

All issues in nmwsharp/geometry-central

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.