Naming Convention for Installer CMake Config Files

Open
#175 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
cmake
Domain
build-system

Research direction

Start by reviewing the installer-generated files under lib/cmake/geometry-central, especially geometrycentral-config.cmake, geometrycentral-config-version.cmake, geometrycentral.cmake, and geometrycentral-relwithdebinfo.cmake. Compare their names with the geometrycentral::geometry-central target and geometrycentral_DIR path, then document or apply the agreed naming convention consistently across the generated CMake configuration.

Written by the indexing model from the issue text.

Description

Hi,

I'm currently writing down the implementation of CMake Config Files generated for the installer.

I was wondering what naming convention you'd prefer. At the moment, the directory structure is:

PS C:\dev\install\geometry-central> Get-ChildItem -Recurse -Name
include
lib
include\geometrycentral
include\geometrycentral\numerical
include\geometrycentral\pointcloud
include\geometrycentral\surface
include\geometrycentral\utilities
include\geometrycentral\numerical\...
include\geometrycentral\pointcloud\...
include\geometrycentral\surface\...
lib\cmake
lib\geometry-central.lib
lib\cmake\geometry-central
lib\cmake\geometry-central\geometrycentral-config-version.cmake
lib\cmake\geometry-central\geometrycentral-config.cmake
lib\cmake\geometry-central\geometrycentral-relwithdebinfo.cmake
lib\cmake\geometry-central\geometrycentral.cmake

Target is named geometrycentral::geometry-central and CMake variable needed to find the config file is

"geometrycentral_DIR": "C:/dev/install/geometry-central/lib/cmake/geometry-central",

Have a good day!

Patrick

Dominant language
C++
Stars
1.3k
Forks
183
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nmwsharp/geometry-central

All issues in nmwsharp/geometry-central

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.