nmfs-ost / nmfs-ost/ss3-source-code

need warning and improved logic for generalized sizecomp

Ouverte
#751 1 commentaire 0 réactions 1 personne assignée Voir sur GitHub

@Rick-Methot-NOAA y travaille déjà.

Depuis le 2/2/2026.

composition in progress
Langage dominant
C++
Étoiles
46
Forks
19
Métriques de merge des PR
Aucune PR mergée en 30 j

Description

A user configured a generalized sizecomp with narrow weight bins for the data. SS3 crashed without providing warning. The problem is that when the setup is using weight bins, a narrow population length bin can translate to weight range that is wider than the user-specified weight bins.
@N-DucharmeBarth-NOAA

The code is designed to detect where the population bin is completely within a data bin and assign all of that pop bin to the data bin, and to detect when there are multiple consecutive pop bins that fall within the same data bin range and assign all of them to that range. It also can detect when a pop bin stradles the upper edge of a data bin and apportion that pop bin to the current and nect data bin, then to correctly move on to the next pop bin.
However, the code cannot detect when the upper edge of a pop bin would skip over a data bin. When this happens, no warning is issued and a crash typically occurs.

  • minimum fix would be to provide a fatal warning in all such circumstances
  • best fix would be to develop an algorithm by which the code would apportion that wide population bin to a range of data bins. Surely such an algorithm has already been developed somewhere and we just need to know what to ask for.

Guide de contribution

Ouvrir le guide de contribution

Par où commencer

  1. Lisez l'issue en entier, puis le guide de contribution du projet.
  2. Signalez en commentaire que vous la prenez — cela évite que deux personnes fassent le même travail.
  3. Forkez le dépôt et travaillez sur une branche.
  4. Ouvrez une pull request qui référence le numéro de l'issue.

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.