Missing resampling use case in tests

Open
#281 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
48/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
testing-qa

Research direction

Start by reading the resampling tests named in the issue, especially test_apply_4d and test_LinearTransformsMapping_apply, along with the linked pull-request discussion. Add coverage for applying one 3D transform across all timepoints of a 4D dataset, then run the relevant test suite and confirm the missing matrix case passes.

Written by the indexing model from the issue text.

Description

Antecedent: https://github.com/nipy/nitransforms/pull/278#discussion_r2276640808

As per codex:

Input spatialimage Transform Covered? Tests exercising the case
3D (incl. 4D singleton) 3D ✅ Yes test_apply_singleton_time_dimension, test_apply_linear_transform, test_displacements_field1, test_displacements_field2, test_apply_transformchain
4D 4D ✅ Yes test_LinearTransformsMapping_apply (functional realignment), test_apply_4d (synthetic per-volume transforms)
3D (incl. 4D singleton) 4D ✅ Yes test_LinearTransformsMapping_apply (moving fieldmap with head-motion transforms)
4D 3D ❌ No No test applies a single 3D transform across multiple timepoints of a 4D dataset (aside from the singleton-time regression check)
Dominant language
Python
Stars
35
Forks
18
Avg merge
21h 48m
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nipy/nitransforms

All issues in nipy/nitransforms

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.