Ensure composition should be implemented with ``__matmul__`` and not ``__rmatmul__``
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 35
- Forks
- 18
- Avg merge
- 21h 48m
- Merged PRs (30d)
- 1
Description
As brought up by Chris in the last bit of https://github.com/nipy/nitransforms/pull/166#issuecomment-1189631982, the right implementation should be carefully considered.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the discussion in pull request #166, especially Chris's linked comment, then locate the composition implementation and compare its matmul and rmatmul behavior. The work is complete when the correct operator is chosen and the composition behavior is covered by appropriate tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend-api-design
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100