nh2 / nh2/haskell-cpu-instruction-counter

Use PERF_FLAG_FD_CLOEXEC

Abierto
#6 0 comentarios 0 reacciones 0 asignados Ver en GitHub
enhancement good first issue help wanted
Lenguaje dominante
Haskell
Estrellas
83
Forks
5
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

as per [man page](http://man7.org/linux/man-pages/man2/perf_event_open.2.html):

```
PERF_FLAG_FD_CLOEXEC (since Linux 3.14)
This flag enables the close-on-exec flag for the created event
file descriptor, so that the file descriptor is automatically
closed on execve(2). Setting the close-on-exec flags at
creation time, rather than later with fcntl(2), avoids
potential race conditions where the calling thread invokes
perf_event_open() and fcntl(2) at the same time as another
thread calls fork(2) then execve(2).
```

We want that.

It will make it less possible to have weird random behaviour if the tested code forks a subprocess.

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.