nf-core / nf-core/variantprioritization
Catch sample name identifier length with validation to avoid errors
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- Nextflow
- Stars
- 16
- Forks
- 11
- PR merge metrics
- No merged PRs in 30d
Description
Description of feature
PCGR reports:
Sample name identifier ('--sample_id' = RevvityOncoSpan-HD827-50ng-Rep1.RevvityOncoSpan-HD827-50ng-Rep1) must be between 3 and 40 characters long, current length is 63
We should catch this when validating the samplesheet to avoid erorring later.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the samplesheet validation entry point and trace how sample names are checked before PCGR runs. Add validation for the stated 3–40 character limit and confirm that an overlong sample identifier is reported during samplesheet validation rather than failing later in PCGR.
Written by the indexing model from the issue text.
Assessment
- Domain
- bioinformatics
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100