Joined participant is not aware, if other participants have `raisedHand` flag

Open
#11,407 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
52/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Quiet
Tech stack
javascript

Research direction

Start by reviewing the speaking-status approach in commit dbcf46c232e7b68eaae6217f6958623d41090fa5 and tracing how the participantModel is sent to recently joined participants. Compare that path with the raisedHand attribute behavior. Done means a newly joined participant receives the current raisedHand value for existing participants, with regression coverage for the reported call sequence.

Written by the indexing model from the issue text.

Description

bug feature: call 📹 feature: frontend 🖌️ feature: signaling 📶

Drawback I found so far:

  • user 1 in call raised his hand (attributes.raisedHand evaluate to { value: true, timestamp: 123 }
  • user 2 joined call
  • client of user 2 receives a participantModel of user 1 with attributes.raisedHand as { value: false, timestamp: 0 }

We most likely could reuse same method for raised hand flag to notify recently joined participants, as for speaking status: https://github.com/nextcloud/spreed/commit/dbcf46c232e7b68eaae6217f6958623d41090fa5

Originally posted by @Antreesy in https://github.com/nextcloud/spreed/issues/11394#issuecomment-1900188958

Dominant language
PHP
Stars
2.2k
Forks
587
Avg merge
17h 55m
Merged PRs (30d)
350

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from nextcloud/spreed

All issues in nextcloud/spreed

Similar issues

More PHP issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.