neurostuff / neurostuff/PyMARE
Parameter alpha (`q`) is not being used by the FDR correction method
Open
Nobody has claimed this yet.
bug
- Dominant language
- Python
- Stars
- 58
- Forks
- 16
- Avg merge
- 5h 7m
- Merged PRs (30d)
- 4
Description
The parameter q is passed to fdr but it's not used:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in pymare/stats.py at the linked lines 178-188 and trace how fdr receives and applies q. Search for existing fdr tests or callers to determine the expected correction behavior, then verify that changing q changes the result without breaking current behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100