neurostuff / neurostuff/PyMARE
Convert permutation tests to functions
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 58
- Forks
- 16
- Avg merge
- 5h 7m
- Merged PRs (30d)
- 4
Description
MetaRegressionResult.permutation_test and CombinationTestResult.permutation_test both require access to the Result object, which is a bit much for NiMARE Estimators to hold onto between the fitting and correction steps. If we could convert the methods to functions, and possibly distinguish the null distribution creation step from the correction step, I think that could help NiMARE.
This stems from https://github.com/neurostuff/NiMARE/issues/278.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with MetaRegressionResult.permutation_test and CombinationTestResult.permutation_test, then trace how NiMARE estimators retain and use the Result object between fitting and correction. Define the intended separation between null distribution creation and correction, and consider how converting these methods to functions affects the estimator workflow.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100