Generally accept whitespace around numbers in XML
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Start by locating the XML reader's readInt and readDouble methods and read the linked pull request discussion for context. Check how each method handles numeric XML values surrounded by whitespace, then verify that both methods accept this input efficiently. Done means general whitespace handling works consistently for integer and double values.
Written by the indexing model from the issue text.
Description
According to the XML schema specification, there may be whitespace around numbers, and this whitespace should be ignored (see https://github.com/musescore/MuseScore/pull/24967#issuecomment-2381444766).
The readInt and readDouble methods of our XML reader fails to parse numbers with whitespace around them. In https://github.com/musescore/MuseScore/pull/24967, this was fixed in a few cases where it was immediately necessary, but there is no reason to assume that we won't ever encounter whitespace elsewhere too. Furthermore, the implemented solution is potentially not optimal in terms of performance, because of string conversions, although the encountered strings are admittedly always going to be relatively short.
Task: implement a general and efficient solution for reading numbers surrounded by whitespace in the readInt and readDouble methods.
- Dominant language
- C++
- Stars
- 15.1k
- Forks
- 3.3k
- Avg merge
- 2d 2h
- Merged PRs (30d)
- 91
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from musescore/MuseScore
-
engraving P3 UI
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
needs design
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
community P3 UI
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
regression nightly UX/interaction
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
All issues in musescore/MuseScore
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
Sensor initialization takes very long when `--initial-sim-time` is set to current UNIX timestamp Open
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
gazebosim/gz-sensors#662 · 1 comment ·
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
comp-datalake
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
ClickHouse/ClickHouse#121222 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
LadybirdBrowser/ladybird#12123 ·