Note highlighting on the piano keyboard ignores ottavas

Open
#21,900 3 comments 1 reaction 2 assignees View on GitHub

@davidfaianunes is already working on this.

Since Apr 2, 2024.

Assessment

This issue has not been assessed yet.

Description

P3 UI
Issue type

UI bug (incorrect info or interface appearance)

Bug description

When one or more notes are selected, the note(s) in the selection get highlighted on the piano keyboard. This highlighting does not account for ottavas, so the wrong key gets highlighted for any note affected by one.

Tested on 4.2.1 and on the most recent nightly build.

Steps to reproduce
  1. add a note to a score
  2. add an ottava to the note
  3. open the piano keyboard
  4. select the note (or the measure containing the note)

Expected result: the key corresponding to the selected note gets highlighted
Actual result: the highlighted key is off by an octave, as if the ottava didn't exist

Screenshots/Screen recordings

No response

MuseScore Version

MuseScore version (64-bit): 4.3.0-240710504, revision: github-musescore-musescore-5be2b33

Regression

I don't know

Operating system

Arch Linux x86_64

Additional context

No response

Dominant language
C++
Stars
15.1k
Forks
3.3k
Avg merge
2d 2h
Merged PRs (30d)
91

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from musescore/MuseScore

All issues in musescore/MuseScore

Similar issues

More C++ issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.