mozilla / mozilla/pontoon

Ureviewed suggestions notifications received by non-reviewers

Open
#4,416 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

hours P3
Dominant language
Python
Stars
1.7k
Forks
611
Avg merge
1d 19h
Merged PRs (30d)
49

Description

I regularly receive notifications about new unreviewed suggestions in projects where I don't hold review (translator) privileges. For example:

Image Image Image

According to https://pontoon.mozilla.org/docs/localizer/notifications/#new-suggestions-ready-for-review:

Recipients include users with permissions to review these suggestions — translator and team managers — as well as the authors of previous translations or comments in the same string.

I can believe that I authored translations of some of the strings for which new suggestions have been submitted... While I don't understand why I need to care about new suggestions anyway, and how I am supposed to differentiate suggestions for strings with my translations and for completely unrelated strings, we could at least adjust the wording for non-reviewers, clarifying that the notification is sent because the suggestions affect strings with their contributions.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the notification behavior described in the issue and compare it with the documented “New suggestions ready for review” rule at pontoon.mozilla.org/docs/localizer/notifications/#new-suggestions-ready-for-review. Trace how recipients and notification wording are selected for non-reviewers who previously contributed to a string. Done means those recipients receive wording that explains why they were notified and distinguishes their contributions from review privileges.

Written by the indexing model from the issue text.

Assessment

Tech stack
django, python
Domain
localization
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.