[not_landed] Clear BugBot needinfos after the patch lands

Open
#3,003 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
66/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Active
Tech stack
python
Domain
backend, tooling

Research direction

Start by locating the not_landed rule and the code that creates its needinfo flags. Trace how the rule detects a published revision or a bug resolved as fixed, then verify that flags created by this rule are cleared in both cases without affecting the broader behavior described in #2404.

Written by the indexing model from the issue text.

Description

The not_landed rule leaves its needinfo flags open after the patch lands and the bug is resolved.

For example, Bug 2057383 was needinfoed by BugBot on August 14. The patch landed and the bug was resolved on August 17, but both needinfos remained open until they were manually cleared on August 20 and August 29.

Because the needinfo is specifically asking about an approved patch that has not landed, it is no longer actionable once the revision is published or the bug is resolved as fixed. BugBot should clear the needinfo flags created by not_landed when that condition is no longer true.

This is related to #2404, but narrower: rather than notifying people about all pending needinfos on closed bugs, not_landed should clean up the flags it created when the patch lands.

Dominant language
Python
Stars
68
Forks
92
Avg merge
2d 2h
Merged PRs (30d)
16

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mozilla/bugbot

All issues in mozilla/bugbot

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.