mozilla / mozilla/bugbot

AttributeError: 'list' object has no attribute 'values'

Open Beginner friendly
#2,979 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
68
Forks
92
Avg merge
2d 2h
Merged PRs (30d)
16

Description

Sentry Issue: BUGBOT-Z6

AttributeError: 'list' object has no attribute 'values'
(2 additional frame(s) were not displayed)
...
  File "bugbot/bzcleaner.py", line 712, in get_email_data
    bugs = self.get_bugs(date=date)
  File "inactive_reviewer.py", line 53, in get_bugs
    revisions = self._get_revisions_with_inactive_reviewers(list(rev_ids))
  File "inactive_reviewer.py", line 170, in _get_revisions_with_inactive_reviewers
    users = self.user_activity.get_phab_users_with_status(
  File "bugbot/user_activity.py", line 300, in get_phab_users_with_status
    ) and self.is_active_on_phab(phab_user["phid"]):
  File "bugbot/user_activity.py", line 329, in is_active_on_phab
    for story in feed.values():

Rule inactive_reviewer

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in bugbot/user_activity.py at is_active_on_phab around line 329, then follow the call from get_phab_users_with_status shown in the traceback. Inspect the Sentry event to determine the feed response shape and verify that the inactive_reviewer path no longer raises AttributeError when processing it.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.