CS_VALUE_TYPE affects parent type if applied to inner class

Open
#559 10 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
cpp, csharp
Domain
tooling

Research direction

The issue names no source files, tests, or entry points. Reproduce the nested C++ example and trace how CS_VALUE_TYPE affects generated C# stubs; done means Record remains a class while only ItemsIterator becomes a struct, with a regression test covering the case.

Written by the indexing model from the issue text.

Description

I expect that Record remain as 'class' in generated stub and only ItemsIterator becomes struct in code below:

class Record
{
    CS_VALUE_TYPE class ItemsIterator
    {
    };
};

But both classes becomes 'struct' in generated stub.

        public unsafe partial struct Record
        {
...
...
            internal unsafe partial struct ItemsIterator
            {

Of cource I can do it by other way

ctx.SetClassAsValueType("ItemsIterator");

but default behaviour of CS_VALUE_TYPE seems to be strange.

Dominant language
C#
Stars
3.4k
Forks
541
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mono/CppSharp

All issues in mono/CppSharp

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.