modelcontextprotocol / modelcontextprotocol/typescript-sdk
codemod v1-to-v2 hoists rewritten imports above the file's license header
Dieses Issue hat noch niemand übernommen.
- Vorherrschende Sprache
- TypeScript
- Sterne
- 13.4k
- Forks
- 2.2k
- Ø Merge
- 3 T. 15 Std.
- Gemergte PRs (30 T.)
- 4
Beschreibung
v1-to-v2 moves a rewritten import above the file's leading comment block. On a file whose leading comment is a license or copyright header, the header stops being the first thing in the file, and any lint rule that enforces header position (eslint-plugin-header, eslint-plugin-notice, SPDX scanners) starts failing on a file it previously passed.
The guide's remedy for layout damage is "run your formatter". Prettier does not move the import back, so this survives the documented cleanup step.
Repro
mkdir -p repro/src && cd repro
cat > package.json <<'EOF'
{ "name": "repro", "version": "1.0.0", "type": "module",
"dependencies": { "@modelcontextprotocol/sdk": "^1.29.0" } }
EOF
cat > src/a.ts <<'EOF'
// Copyright (c) 2026 Example Corp.
// SPDX-License-Identifier: Apache-2.0
import type { CallToolResult } from '@modelcontextprotocol/sdk/types.js';
export const ok = (): CallToolResult => ({ content: [] });
EOF
npx @modelcontextprotocol/codemod@2.0.0 v1-to-v2 .
cat src/a.ts
Actual:
import type { CallToolResult } from "@modelcontextprotocol/server";
// Copyright (c) 2026 Example Corp.
// SPDX-License-Identifier: Apache-2.0
export const ok = (): CallToolResult => ({ content: [] });
Expected: the import stays where it was, below the header.
// Copyright (c) 2026 Example Corp.
// SPDX-License-Identifier: Apache-2.0
import type { CallToolResult } from "@modelcontextprotocol/server";
export const ok = (): CallToolResult => ({ content: [] });
Two things go wrong in those six lines. The import is hoisted above the header, and the blank line that separated the header from export const ok is consumed, so the header now reads as that declaration's doc comment.
Running npx prettier@latest --write src/a.ts afterwards produces byte-identical output, so step 5 of the TL;DR does not cover this.
Second shape, same cause
When the leading comment is a multi-line // run and the rewritten import is not the first import in the file, the import is inserted inside the comment run rather than above it. From a real migration:
// page_to_markdown tool: fetches a URL and returns clean Markdown for LLM context.
import type { CallToolResult } from "@modelcontextprotocol/server";
// Uses @page2ai/core under the hood — inherits SSRF protection, 10MB size cap,
// 15s AbortController timeout, `.md`-first attempt (Mintlify convention), and
// static tab discovery (emits `### Tab: {label}` sections for docs sites).
import { fetchAndConvert } from '@page2ai/core';
Line 1 of a four-line file comment now sits alone above an unrelated import. Prettier leaves this one alone too.
Both look like the same root cause: the new import node is attached at a position derived from the old node without carrying the leading comments with it.
Environment
@modelcontextprotocol/codemod2.0.0- Node 24.14.1, npm 11.13.0, Windows 11
- Migrating a published stdio server (
@modelcontextprotocol/sdk@^1.29.0to@modelcontextprotocol/server@^2.0.0)
Everything else in the run was correct, including the zod >= 4.2.0 floor warning, which was accurate and saved a debugging session: the ZodError.errors to .issues rename only surfaces at type-check.
Beitragsleitfaden
Erste Schritte
- Lies das ganze Issue und danach den Beitragsleitfaden des Projekts.
- Schreib ins Issue, dass du es übernimmst — das erspart doppelte Arbeit.
- Forke das Repository und arbeite in einem Branch.
- Öffne einen Pull Request, der die Issue-Nummer nennt.
Rechercherichtung
Führe zunächst die bereitgestellte Reproduktion mit dem v1-to-v2-Einstiegspunkt aus und untersuche den Pfad zum Umschreiben von Imports im codemod. Füge Regressionstests für beide im Issue beschriebenen Formen des führenden Headers hinzu. Erledigt ist die Aufgabe, wenn umgeschriebene Imports unterhalb des vollständigen führenden Kommentarblocks bleiben, die trennende Leerzeile erhalten bleibt und der dokumentierte Formatierungsschritt den Header nicht mehr an der falschen Stelle zurücklässt.
Vom Indexierungsmodell aus dem Issue-Text verfasst.
Bewertung
- Tech-Stack
- node.js, typescript
- Bereich
- tooling
- Issue-Typ
- Bug
- Schwierigkeit
- 3/5
- Geschätzter Aufwand
- 1-2 Tage
- Aktivitätsstatus
- Ruhig
- Klarheit
- Größtenteils klar
- Anfängerfreundlichkeit
- 67/100