modelcontextprotocol / modelcontextprotocol/python-sdk
ClientSession.call_tool issues a tools/list after every tools/call when the output-schema cache is empty — no opt-out; doubles round-trips on per-call sessions
還沒有人認領這個 Issue。
- 主要語言
- Python
- 星號
- 24.3k
- 分支
- 4k
- 平均合併
- 1 天 1 小時
- 30 天內合併 PR
- 31
描述
Summary
ClientSession.call_tool() issues a tools/list request after every successful tools/call whenever the called tool is not in the session's output-schema cache. On a short-lived session — one ClientSession per tools/call, the pattern gateways and proxies use when the downstream caller is stateless — the cache is empty on every call, so every call_tool costs two round-trips instead of one (initialize + notifications/initialized + tools/call + tools/list = 4 POSTs on Streamable HTTP instead of 3).
When the server behind the session is itself an aggregator whose tools/list fans out to N backends, the extra request is N upstream calls, and the slowest backend's tools/list latency is added to every call_tool — including calls to tools that declare no outputSchema and have nothing to validate.
There is no way to opt out short of subclassing ClientSession or patching the method.
Where
mcp 1.29.1, src/mcp/client/session.py:
# :386-415
async def call_tool(self, name, arguments=None, read_timeout_seconds=None, progress_callback=None, *, meta=None):
...
result = await self.send_request(...)
if not result.isError:
await self._validate_tool_result(name, result)
return result
# :417-421
async def _validate_tool_result(self, name: str, result: types.CallToolResult) -> None:
"""Validate the structured content of a tool result against its output schema."""
if name not in self._tool_output_schemas:
# refresh output schema cache
await self.list_tools()
...
Still present on main @ 6affe5c0 (2026-09-16) as the public validate_tool_result, :1118-1127 — the cache is populated only by list_tools() (_absorb_tool_listing), and _tool_output_schemas is per-ClientSession, so a fresh session always pays the refresh.
Reproduction
import anyio
from mcp import ClientSession
from mcp.client.streamable_http import streamablehttp_client
async def main():
async with streamablehttp_client("http://127.0.0.1:8000/mcp") as (r, w, _):
async with ClientSession(r, w) as s:
await s.initialize()
await s.call_tool("echo", {"text": "hi"}) # server access log: POST initialize, POST initialized, POST tools/call, POST tools/list
anyio.run(main)
Any FastMCP server with a tool that returns unstructured content shows the fourth POST. Measured against a proxy whose tools/list fans out to six backends: call_tool wall time p50 ≈ 3 s / p99 ≈ 36 s through the proxy vs p99 0.24 s calling the backend directly — the gap is entirely the post-result tools/list waiting on the slowest backend.
Proposed change (any of these would do)
- A constructor opt-out, e.g.
ClientSession(..., validate_tool_results: bool = True); whenFalse,call_toolreturns the result without callingvalidate_tool_result. Callers that already validate structured output elsewhere (a gateway with its own schema plugin, a server that validates before responding) can turn the client-side re-validation off. - Do not refresh on an empty cache. If the session has never listed tools,
validate_tool_resultcannot know whether the tool has anoutputSchema; today it spends a round-trip to find out. Skipping the refresh whennot self._tool_output_schemas(and keeping it when the cache is populated but lacks the tool — a tool added since the last listing) removes the cost on per-call sessions while leaving long-lived sessions unchanged. A DEBUG log line on the skip keeps it observable. - Validate only when the result carries
structuredContent. A result with nostructuredContentfrom a tool with no cached schema has nothing to check; the refresh then only serves to raiseRuntimeError("… has an output schema but did not return structured content")for a tool the client never listed — a stricter contract than the server side enforces.
Option 2 is what we are running as a build-time patch on a vendored 1.29.1 (one three-line hunk in _validate_tool_result); happy to open a PR for whichever shape the maintainers prefer.
Environment
mcp1.29.1 (Python 3.12); also reproduces onmain@6affe5c0- Transport: Streamable HTTP, stateless server (no
Mcp-Session-Id), oneClientSessionper call
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
從 src/mcp/client/session.py 中的 ClientSession.call_tool 和 _validate_tool_result 開始,接著檢查 list_tools 和 _absorb_tool_listing,以了解快取填入的方式。執行 Streamable HTTP 重現並確認目前的要求序列。當所選行為能避免不必要的 tools/list 往返,同時保留預期的輸出 schema 驗證時,即可完成。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- python
- 領域
- api, performance
- Issue 類型
- 缺陷
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 活躍度
- 活躍
- 描述清晰度
- 基本清楚
- 新手友好度
- 72/100