modelcontextprotocol / modelcontextprotocol/python-sdk
[v2] Add an end-to-end public-client PKCE server contract
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Python
- Estrellas
- 24.3k
- Forks
- 4k
- Merge medio
- 1 d 1 h
- PR fusionados (30 d)
- 31
Descripción
What happened?
With mcp==2.1.1, an MCP authorization server still cannot advertise and register an OAuth public client consistently without downstream patching:
build_metadata()does not includenoneintoken_endpoint_auth_methods_supported.RegistrationHandlerdefaults an omittedtoken_endpoint_auth_methodtoclient_secret_post, minting a secret even for clients intending to operate as PKCE public clients.- The individual token handler pieces support
token_endpoint_auth_method="none"when it is explicitly supplied, but there is no end-to-end SDK test pinning discovery -> DCR -> authorization-code/PKCE token exchange for a public client.
This is related to #2260, which was closed, and #2261, which remains open. The inconsistency is still present in the published v2 SDK.
For a real MCP server integration, we currently have to monkeypatch metadata generation and DCR's omitted-method behavior at import time. Those patches depend on private implementation details and are difficult to remove safely without a supported end-to-end public-client contract.
What did you expect?
The v2 server auth surface should support a complete public-client PKCE flow without monkeypatching:
- Authorization-server metadata advertises
none. - DCR preserves an explicit
token_endpoint_auth_method="none"and has a documented, interoperable default for omitted methods. - The token endpoint accepts the registered public client without a client secret and verifies the PKCE
code_verifieragainst the authorization code's challenge. - An SDK integration test covers the full flow so future releases do not regress it.
Merging or superseding #2261 plus adding the end-to-end test would provide a clear downstream exit condition.
Code to reproduce
from mcp.server.auth.handlers.register import RegistrationHandler
from mcp.server.auth.routes import build_metadata
# In mcp==2.1.1:
# - build_metadata() omits "none" from token_endpoint_auth_methods_supported
# - RegistrationHandler.handle defaults an omitted token_endpoint_auth_method
# to "client_secret_post"
SDK version
2.1.1
Area
Auth
Related
- #2260
- #2261
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Empieza por mcp.server.auth.routes.build_metadata y mcp.server.auth.handlers.register.RegistrationHandler; después, sigue los handlers de tokens de authorization code/PKCE y las pruebas de autenticación existentes del SDK. El trabajo estará terminado cuando el discovery no anuncie ningún método, el registro gestione de forma coherente los métodos explícitos y omitidos, el intercambio de tokens verifique el PKCE code_verifier sin un secret y una prueba de integración end-to-end cubra el flujo.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- authentication, backend-api-design, security
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Activo
- Claridad
- Bastante claro
- Aptitud para principiantes
- 50/100