modelcontextprotocol / modelcontextprotocol/python-sdk
StreamableHTTP: a client disconnect while reading the POST body is logged as an exception and answered 500
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- Python
- Estrellas
- 24.3k
- Forks
- 4k
- Merge medio
- 1 d 1 h
- PR fusionados (30 d)
- 31
Descripción
Initial Checks
- I confirm that I'm using the newest release of my line (the latest 2.x, or the latest 1.x if I'm still on v1)
- I confirm that I searched for my issue in https://github.com/modelcontextprotocol/python-sdk/issues before opening this issue
Release line
2.x (current stable), and the same on 1.28.1
Description
StreamableHTTPServerTransport._handle_post_request reads the request body inside its blanket except Exception. When the client goes away before the body arrives, await request.body() raises starlette.requests.ClientDisconnect, the transport logs it with logger.exception("Error handling POST request") and answers 500. That is a normal network event on a public MCP endpoint (mobile clients, proxies with short timeouts, health probes), and it lands as an unhandled server error with a stack trace in every log aggregator. #2064 / #2257 handled the disconnect in _handle_message; this is the earlier point, in streamable_http.py (the body = await request.body() line and the except Exception as err below it). The SSE transport has no handling for it either.
Example Code
import asyncio
import importlib.metadata as md
import logging
from mcp.server.streamable_http import StreamableHTTPServerTransport
records = []
class Capture(logging.Handler):
def emit(self, record):
records.append(record)
logging.getLogger("mcp").addHandler(Capture())
logging.getLogger("mcp").setLevel(logging.DEBUG)
async def main():
transport = StreamableHTTPServerTransport(mcp_session_id=None)
scope = {
"type": "http", "method": "POST", "path": "/mcp", "query_string": b"", "headers": [
(b"content-type", b"application/json"),
(b"accept", b"application/json, text/event-stream"),
(b"content-length", b"58"),
],
}
async def receive(): # the client went away before sending its body
return {"type": "http.disconnect"}
sent = []
async def send(message):
sent.append(message)
async with transport.connect():
try:
await asyncio.wait_for(transport.handle_request(scope, receive, send), timeout=5)
except asyncio.TimeoutError:
print("handle_request did not return within 5s")
status = next((m["status"] for m in sent if m["type"] == "http.response.start"), None)
print(f"mcp {md.version('mcp')}: response status = {status}")
for r in records:
if r.levelno >= logging.ERROR:
print(f" logged {r.levelname} by {r.name}: {r.getMessage()} | exc: {type(r.exc_info[1]).__name__ if r.exc_info else None}")
try:
asyncio.run(asyncio.wait_for(main(), timeout=15))
except asyncio.TimeoutError:
print("main did not finish within 15s")
Output on 1.28.1 and 2.1.1:
mcp 2.1.1: response status = 500
logged ERROR by mcp.server.streamable_http: Error handling POST request | exc: ClientDisconnect
(The script caps handle_request at 5 s because the stub send / receive is not a real ASGI server; the 500 and the log line are sent before that.)
Expected: ClientDisconnect caught before the generic handler, logged at debug or info, and no response attempted, since there is nobody to answer.
Python & MCP Python SDK
Python 3.12.13, mcp 1.28.1 and 2.1.1, starlette 1.3.1, macOS
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza en mcp/server/streamable_http.py, en StreamableHTTPServerTransport._handle_post_request, especialmente en la línea body = await request.body() y el siguiente manejador de excepciones genérico. Compara el manejo existente de las desconexiones en _handle_message al que se hace referencia en #2064 y #2257. Se considera terminado cuando ClientDisconnect se maneja sin un stack trace de error ni una respuesta 500, y la cobertura de regresión verifica este comportamiento.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- python
- Área
- api, backend
- Tipo de issue
- Error
- Dificultad
- 2/5
- Tiempo estimado
- 1-3 horas
- Estado de actividad
- Activo
- Claridad
- Bien especificado
- Aptitud para principiantes
- 78/100