modelcontextprotocol / modelcontextprotocol/python-sdk

A tool returning a non-finite float puts invalid JSON in the text content block

Aperta
#3,385 1 commento 0 reazioni 0 assegnatari Vedi su GitHub

Nessuno ha ancora preso questa issue.

v1 v2
Lingua principale
Python
Stelle
24.3k
Fork
4k
Merge medio
1g 1h
PR unite (30g)
31

Descrizione

Initial Checks
Release line

2.x (current stable), and it reproduces on the latest 1.x too.

Description

This is a different code path from #3341, which I filed for the structured-output case. Same input, different failure, and the two behave inconsistently with each other, so I am reporting it separately. Happy to fold it into #3341 if you would rather track them together.

When a tool has no return annotation, no output schema is generated and the result is rendered to a text block by pydantic_core.to_json(result, fallback=str, indent=2) (func_metadata.py:669 on 2.1.0). to_json writes non-finite floats as the bare tokens NaN and Infinity. RFC 8259 does not allow either, so the text block is not valid JSON. is_error is False, so the call reports success.

The text block sent to the client:

{
  "mean": 1.5,
  "stddev": NaN,
  "max": Infinity
}

Python's json.loads accepts this, because it is lenient about those tokens by default. A spec-compliant parser does not. Node:

> JSON.parse('{"mean":1.5,"stddev":NaN,"max":Infinity}')
SyntaxError: Unexpected token 'N', ..."stddev":NaN,"max":"... is not valid JSON

So the same tool result is readable from a Python client and breaks a TypeScript one.

What I expected: a text content block holding JSON should be parseable by any JSON parser, or the SDK should fail at the server with an error that names the serialisation problem.

Worth noting alongside #3341: for the same input, the structured path silently converts the value to null and the text path emits invalid JSON. Whatever the fix is, it would be good if those two agreed.

The same to_json(..., fallback=str, indent=2) call is used in resources/types.py:103, and prompts/base.py:206 follows the same pattern, so the fix probably wants to cover those too.

Example Code
import json
import math

import anyio
from mcp.client.client import Client
from mcp.server.mcpserver import MCPServer

server = MCPServer("stats")


@server.tool()
def summarise():
    """No return annotation, so the result goes out as a text block."""
    return {"mean": 1.5, "stddev": math.nan, "max": math.inf}


async def main() -> None:
    async with Client(server) as client:
        result = await client.call_tool("summarise")
        text = result.content[0].text
        print("is_error:", result.is_error)
        print("text block:", text)
        # Reject NaN/Infinity the way a spec-compliant parser does.
        json.loads(text, parse_constant=lambda c: (_ for _ in ()).throw(ValueError(f"invalid JSON token: {c}")))


anyio.run(main)

Output:

is_error: False
text block: {
  "mean": 1.5,
  "stddev": NaN,
  "max": Infinity
}
ValueError: invalid JSON token: NaN
Python & MCP Python SDK
Python 3.13.11, Linux.

mcp 2.1.0  (latest 2.x): func_metadata.py:669
mcp 1.29.1 (latest 1.x): fastmcp/utilities/func_metadata.py:558
Also reproduces on main at d8b63830.

Reported with AI assistance; I ran the reproduction above and read the output.

Guida per i contributori

Apri la guida per i contributori

Come iniziare

  1. Leggi tutta la issue e poi la guida ai contributi del progetto.
  2. Commenta sulla issue per dire che te ne occupi tu — evita che due persone facciano lo stesso lavoro.
  3. Fai un fork del repository e lavora su un branch.
  4. Apri una pull request che faccia riferimento al numero della issue.

Direzione di ricerca

Inizia da func_metadata.py:669, dove pydantic_core.to_json serializza i risultati degli strumenti privi di annotazioni, e confronta la stessa chiamata in resources/types.py:103 e prompts/base.py:206. Verifica il comportamento dell’output strutturato descritto in #3341. Il lavoro è completato quando i valori non finiti non producono più JSON non valido, oppure il server segnala un errore di serializzazione, e i percorsi interessati si comportano in modo coerente.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
python
Ambito
api, backend
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Attiva
Chiarezza
Abbastanza chiara
Idoneità per principianti
68/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.