modelcontextprotocol / modelcontextprotocol/python-sdk
Bug: OAuth provider holds context.lock for the whole request, so the standalone GET SSE stream stalls the first tools/call by ~15s
还没有人认领这个 Issue。
- 主要语言
- Python
- 星标
- 24.3k
- 派生
- 4k
- 平均合并
- 1 天 1 小时
- 30 天内合并 PR
- 31
描述
Summary
With auth=OAuthClientProvider on a streamable-HTTP connection, the first tools/call of every session blocks for ~15 s. No error, no warning — just latency. Nothing is concurrent here: one server, one client, one session, sequential calls.
Root cause is the same context.lock-held-across-yield problem as #2847 / #2644, but the symptom is different enough that it seems worth recording separately: #2847 is about RuntimeError: The current task is not holding this lock under concurrent OAuth connections, while this is a silent latency tax paid by every OAuth streamable-HTTP user, concurrency or not. Both are fixed by #2858.
Environment
mcp==1.29.0,anyio==4.13.0,httpx==0.28.1- Python 3.14.6, macOS arm64
- Server: FastMCP behind Google Cloud Run, streamable HTTP, OAuth 2.1 + PKCE
Measurement
Same server, same tool, one fresh session per call, three calls per arm. The only variable is how the bearer token reaches the request:
auth=OAuthClientProvider : 15.68s / 15.74s / 15.80s
static Authorization header: 0.70s / 0.62s / 0.67s
Raw HTTP JSON-RPC against the same endpoint (no SDK) answers the same tool in ~0.07 s, so the useful work is ~100 ms and effectively all of the 15.7 s is the wait.
Repro:
import time, anyio
from mcp.client.session import ClientSession
from mcp.client.streamable_http import streamablehttp_client
async def one(*, use_provider: bool) -> float:
headers = None if use_provider else {"Authorization": f"Bearer {ACCESS_TOKEN}"}
auth = build_provider() if use_provider else None # OAuthClientProvider
t0 = time.perf_counter()
async with streamablehttp_client(URL, headers=headers, auth=auth) as (r, w, _):
async with ClientSession(r, w) as session:
await session.initialize()
await session.call_tool("get_last_modified", {})
return time.perf_counter() - t0
Why it happens
async_auth_flowtakescontext.lockand holds it for the whole lifetime of the request, not just while it obtains a token — theasync with self.context.lock:atsrc/mcp/client/auth/oauth2.py:492wrapsresponse = yield request.- After
initialized,streamablehttp_clientopens the long-lived standalone GET SSE stream. - That GET goes through
async_auth_flow, takes the lock, and does not release it until the stream ends — 15–60 s in our logs, dictated by the server's/proxy's idle timeout, not by the client. - The first
tools/calltherefore waits on the lock for as long as the GET stream lives. - Once the stream closes, subsequent calls run at ~100 ms until the next stream is opened.
So the stall is not a fixed 15 s: it is "however long the server keeps an idle SSE stream open", which for Cloud Run happens to be ~15 s and for other deployments in this thread ~60 s.
The fix
#2858 (rebase of #2660 by @peisuke) already does the right thing: no HTTP yield — including the standalone GET SSE long-poll — runs while context.lock is held. Verified locally that with the lock out of the request path the same call is ~0.4–0.7 s.
Our workaround in the meantime is to keep OAuthClientProvider out of the request path entirely: read the token from storage and pass it as a plain Authorization header, refreshing it ourselves. That is a fine escape hatch for an application, but it means giving up the SDK's auth handling, which most users reasonably will not want to do.
Would a maintainer be able to look at #2858? It fixes a correctness bug for concurrent users and a ~15 s per-session latency bug for everyone else.
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 src/mcp/client/auth/oauth2.py 第 492 行附近和 streamablehttp_client 入口点开始,然后与 #2858 中提出的修复进行比较。使用提供的脚本复现独立的 GET SSE 流程,并验证请求不再等待 OAuth context lock,且第一次 tools/call 可避免 stream 生命周期导致的延迟。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- python
- 领域
- api, authentication
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 描述清楚
- 新手友好度
- 25/100