modelcontextprotocol / modelcontextprotocol/python-sdk
RequestResponder.__exit__ leaks CancelledError on cancelled request, killing the stdio receive loop
還沒有人認領這個 Issue。
- 主要語言
- Python
- 星號
- 24.3k
- 分支
- 4k
- 平均合併
- 1 天 1 小時
- 30 天內合併 PR
- 31
描述
Summary
When a client sends notifications/cancelled for an in-flight request handled over stdio, the server's receive loop task group dies. The process stays alive but stops reading stdin, so every subsequent request hangs and the client eventually reports MCP error -32000: Connection closed. The bug is racy — it reproduces in roughly 40–80% of attempts depending on platform timing.
Affects: mcp 1.26.0 and 1.27.1 (latest at time of writing). Confirmed with FastMCP 3.1.x and the in-tree stdio server.
Reproduction
A standalone subprocess test is in mlorentedev/hive tests/test_transport_recovery.py. The relevant flow:
initialize→ acknotifications/initializedtools/call id=2notifications/cancelledforrequestId=2(within a few ms of step 3)- Receive:
{"id": 2, "error": {"code": 0, "message": "Request cancelled"}}← OK tools/call id=3- No response. Server is alive but
proc.stdout.readline()hangs.
Root cause
mcp.shared.session.RequestResponder.__exit__:
def __exit__(self, exc_type, exc_val, exc_tb):
try:
if self._completed:
self._on_complete(self)
finally:
self._entered = False
...
self._cancel_scope.__exit__(exc_type, exc_val, exc_tb) # ← (A)
When notifications/cancelled arrives, RequestResponder.cancel() calls self._cancel_scope.cancel() and sends the error response. The handler task catches the CancelledError in mcp/server/lowlevel/server.py (around line 766) and returns. The with responder: block then exits with exc_type=None while the cancel scope is still in cancelled state — at line (A), anyio's CancelScope.__exit__ re-raises CancelledError.
That exception bubbles up to:
async with anyio.create_task_group() as tg:
async for message in session.incoming_messages:
tg.start_soon(self._handle_message, ...)
…in Server._run. anyio task groups cancel all sibling tasks and propagate the cancellation. The receive loop is one of those sibling tasks, so it dies.
Suggested fix
Swallow the spurious cancellation when the responder has already sent its response:
def __exit__(self, exc_type, exc_val, exc_tb):
try:
if self._completed:
self._on_complete(self)
finally:
self._entered = False
if not self._cancel_scope:
raise RuntimeError("No active cancel scope")
try:
self._cancel_scope.__exit__(exc_type, exc_val, exc_tb)
except BaseException as exc:
if self._completed and isinstance(exc, anyio.get_cancelled_exc_class()):
# cancel() already sent the error response — the scope's
# re-raised cancellation is spurious.
return
raise
Mirrors what we ship in hive src/hive/_compat.py.
Workaround used downstream
We monkey-patch RequestResponder.__exit__ at import time. The patch is self-gated (only fires when _completed=True AND the leaking exception is anyio.get_cancelled_exc_class()), so it stays inert once a fix lands upstream.
Environment
- Reproduced on Windows 11 (
mcp1.26.0, 1.27.1) and via Claude Code as the host. - Tracked downstream in mlorentedev/hive#75.
- Regression test passes 5/5 with the patch applied on Python 3.12; fails 2/5 — 4/5 without it.
- Python 3.13 appears to have additional uncancel semantics that the patch does not yet fully cover — verification in progress.
貢獻指南
從這裡開始
- 先讀完整個 Issue,再讀專案的貢獻指南。
- 在 Issue 下留言說明你要接手 —— 這能避免兩個人做同樣的事。
- Fork 儲存庫,在一個分支上完成修改。
- 送出 Pull Request,並在描述裡引用這個 Issue 編號。
研究方向
從 mcp.shared.session.RequestResponder.exit 開始,檢查 mcp/server/lowlevel/server.py 第 766 行附近的取消處理。使用 tests/test_transport_recovery.py 重現,然後驗證取消一個 stdio 請求仍會產生其錯誤回應,且後續請求能夠收到回應,而不會導致接收迴圈停止。
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- python
- 領域
- api, backend
- Issue 類型
- 缺陷
- 難度
- 3/5
- 預估耗時
- 1-2 天
- 活躍度
- 冷清
- 描述清晰度
- 描述清楚
- 新手友好度
- 68/100