modelcontextprotocol / modelcontextprotocol/php-sdk
[Client] Fill elicitation defaults when accepting (SEP-1034)
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 1.6k
- Forks
- 173
- Avg merge
- 2d 49m
- Merged PRs (30d)
- 23
Description
Context
SEP-1034 adds client-side default handling for elicitation/create. When a client accepts an elicitation request without explicit field values, the response content should be auto-populated from default fields declared in the request's requestedSchema. Schemas already expose default on StringSchemaDefinition, NumberSchemaDefinition, EnumSchemaDefinition, TitledEnumSchemaDefinition, and BooleanSchemaDefinition.
Scope
- Add helper
ElicitationSchema::extractDefaults(): array<string, mixed>returning afield => defaultmap for all properties that declare one. - Document the helper as the canonical "accept-with-defaults" path; update the example in
tests/Conformance/client.phpto use it forelicitation-sep1034-client-defaults. - Optional convenience:
ElicitResult::accepted(ElicitationSchema $schema)factory that pre-fills defaults.
Conformance scenarios unblocked
elicitation-sep1034-client-defaults.
Dependencies
Independent.
Acceptance
- Unit test on
ElicitationSchema::extractDefaultscovering all 5 definition types. - Conformance: scenario passes (after #328 wiring lands, see below).
cc @soyuka
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with ElicitationSchema and the five schema definition types that expose default values, then inspect tests/Conformance/client.php and the elicitation-sep1034-client-defaults scenario. Add the extractDefaults unit coverage and update the example to use the helper; done means all five types are covered and the conformance scenario passes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- php
- Domain
- api
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 72/100