modelcontextprotocol / modelcontextprotocol/php-sdk
[Streamable HTTP][Server] GET should open a server→client SSE listener
Nadie ha tomado este issue todavía.
- Lenguaje dominante
- PHP
- Estrellas
- 1.6k
- Forks
- 173
- Merge medio
- 2 d 49 min
- PR fusionados (30 d)
- 23
Descripción
Problem
StreamableHttpTransport only handles OPTIONS, POST, and DELETE. GET falls into the match default arm and gets a 405 Method Not Allowed with Allow: POST, DELETE, OPTIONS.
vendor/mcp/sdk/src/Server/Transport/StreamableHttpTransport.php (current main):
return match ($request->getMethod()) {
'OPTIONS' => $this->handleOptionsRequest(),
'POST' => $this->handlePostRequest(),
'DELETE' => $this->handleDeleteRequest(),
default => $this->createErrorResponse(Error::forInvalidRequest('Method Not Allowed'), 405),
};
This contradicts both the MCP spec and the SDK's own CORS advertisement on the same class:
'Access-Control-Allow-Methods' => 'GET, POST, DELETE, OPTIONS',
Per the MCP Streamable HTTP transport spec, a client may issue GET against the MCP endpoint to open a long-lived SSE channel for server→client messages (notifications and server-initiated requests outside the request/response loop). Refusing the GET breaks that channel.
Observed impact
Spec-conformant clients open this listener immediately after initialize. The 405 kills the channel. In our deployment we see two session rows created in the session store on every fresh client startup — one for the working POST request/response loop, one orphaned from the failed listener that the client retries under a new session id.
Proposal
Add handleGetRequest() to StreamableHttpTransport and route GET to it from the match in handleRequest().
Behavior:
- Require
Mcp-Session-Id; without it return400(consistent withhandleDeleteRequest()). - Validate the session exists in the configured
SessionStoreInterface; on miss return404. - Open an SSE response (
Content-Type: text/event-stream) and stream:- any queued outgoing messages for this session (the same queue
flushOutgoingMessages()already drains increateStreamedResponse()); - server-initiated requests/notifications produced via the existing
Protocol/Fibermachinery.
- any queued outgoing messages for this session (the same queue
- Honor
Last-Event-IDfor resumption per the spec (can land in a follow-up; the initial PR can document the gap). - Cleanly terminate when the client disconnects.
The mechanics already exist — CallbackStream and flushOutgoingMessages() from PR #109 do the streaming half inside handlePostRequest(). The new method is essentially the same loop without a triggering POST body.
Backward compatibility
Purely additive. Clients that never issue GET see no change. The Access-Control-Allow-Methods header already advertises GET, so the surface is unchanged from the client's perspective — only the server's response to a method it claims to accept changes from 405 to a valid SSE stream.
Related
- PR #109 — added
CallbackStream+flushOutgoingMessages()for SSE insidehandlePostRequest. Provides the streaming primitives this proposal reuses. - Issue #226 — fixed the previous
500response for unsupported methods to405 + Allow. That work treatedGETas legitimately unsupported; this issue arguesGETis actually supported by the spec and should be wired up. - Issue #275 — separate concurrency race on the per-session outgoing message queue. Independent, but a working
GETlistener will exercise the same queue and would benefit from the same fix.
Guía de contribución
Primeros pasos
- Lee el issue completo y luego la guía de contribución del proyecto.
- Comenta en el issue que vas a ocuparte — evita que dos personas hagan lo mismo.
- Haz un fork del repositorio y trabaja en una rama.
- Abre un pull request que haga referencia al número del issue.
Línea de trabajo
Comienza en vendor/mcp/sdk/src/Server/Transport/StreamableHttpTransport.php, siguiendo handleRequest(), handlePostRequest(), createStreamedResponse(), CallbackStream y flushOutgoingMessages(). Reutiliza la validación de sesión y las rutas de streaming existentes según corresponda; después, verifica que GET requiera una sesión válida, produzca una respuesta SSE, vacíe los mensajes en cola y termine limpiamente al desconectarse.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- php
- Área
- api, backend
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Tranquilo
- Claridad
- Bastante claro
- Aptitud para principiantes
- 48/100