modelcontextprotocol / modelcontextprotocol/java-sdk
StdioServerTransportProvider should support a stdin-close callback without interrupting shutdown
还没有人认领这个 Issue。
- 主要语言
- Java
- 星标
- 3.7k
- 派生
- 1.1k
- 平均合并
- 1 天 15 小时
- 30 天内合并 PR
- 9
描述
For stdio-based MCP servers, stdin closing is effectively the client disconnect signal. This is especially important when an MCP server runs in a container: once the MCP client disconnects or closes stdin, the server should be able to trigger application shutdown and clean up background resources.
Today, StdioServerTransportProvider closes the MCP session when stdin reaches EOF, but it does not expose a public transport-level callback that applications can use to run shutdown logic.
Downstream, we had to vendor/copy StdioServerTransportProvider to add such a callback.
Current behavior
When the stdin read loop exits, the SDK transport does roughly this:
finally {
isClosing.set(true);
if (session != null) {
session.close();
}
inboundSink.tryEmitComplete();
}
The session is closed, but the application has no direct hook to react to the stdio client disconnect.
There is also a subtle ordering issue. handleIncomingMessages() currently disposes the inbound scheduler from doOnTerminate():
this.inboundSink.asFlux()
.flatMap(message -> session.handle(message))
.doOnTerminate(() -> {
this.outboundSink.tryEmitComplete();
this.inboundScheduler.dispose();
})
.subscribe();
When stdin closes, the inbound read loop completes inboundSink. The termination callback can run on the same inbound thread. Disposing the scheduler there may call shutdownNow(), interrupting that same thread before downstream shutdown work has completed.
We observed this downstream: shutdown logic could run with the current thread interrupt flag already set, causing graceful shutdown to fail or exit early.
Expected behavior
StdioServerTransportProvider should allow applications to register an optional callback for stdin EOF / stdio client disconnect.
That callback should run:
- After the session is closed.
- After the inbound sink is completed.
- Before the inbound scheduler is disposed.
- Without the current thread being interrupted by scheduler disposal.
Proposed fix
Add an optional callback to StdioServerTransportProvider, for example as a Runnable:
public StdioServerTransportProvider(
McpJsonMapper jsonMapper,
InputStream inputStream,
OutputStream outputStream,
Runnable closeCallback
)
Or, if a reactive API is preferred:
Supplier<Mono<Void>> closeCallback
Then move inboundScheduler.dispose() out of handleIncomingMessages().doOnTerminate(...) and into the inbound read-loop finally, after the callback has completed.
The inbound read-loop cleanup would look conceptually like this:
finally {
isClosing.set(true);
if (session != null) {
session.close();
}
inboundSink.tryEmitComplete();
if (closeCallback != null) {
closeCallback.run();
}
inboundScheduler.dispose();
}
handleIncomingMessages() should still complete the outbound sink, but should not dispose the inbound scheduler from the termination callback.
Suggested regression test
Add a test that:
- Creates a
StdioServerTransportProviderwith a piped input stream. - Registers a callback.
- Starts the transport with a mock session.
- Closes the piped output stream to simulate stdin EOF.
- Verifies the callback runs.
- Verifies
Thread.currentThread().isInterrupted()isfalseinside the callback.
贡献指南
从这里开始
- 先读完整个 Issue,再读项目的贡献指南。
- 在 Issue 下留言说明你要接手 —— 这能避免两个人做同样的事。
- Fork 仓库,在一个分支上完成修改。
- 提交 Pull Request,并在描述里引用这个 Issue 编号。
调研方向
从 StdioServerTransportProvider 开始,重点查看 stdin 读取循环和 handleIncomingMessages() 的终止处理。添加建议的 piped-stream 回归测试,然后验证 callback 在 session 和 inbound-sink 清理之后、scheduler 释放之前运行,并且 callback 线程未被中断。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- java
- 领域
- backend
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 冷清
- 描述清晰度
- 描述清楚
- 新手友好度
- 68/100