mne-tools / mne-tools/mne-python
Add fiducial point check in _read_xyz
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3.5k
- Forks
- 1.6k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 100
Description
Hi everyone.
Would it be a good idea to add a check for fiducial points in _read_xyz function? Right now I am dealing with a custom montage in .csv format where nasion, lpa and rpa coordiantes are written into the csv. By checking for some standard namings ('nasion', 'nz', 'lpa', 'rpa') in ch_pos we could extract their coordinates and pass them into make_dig_montage.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading _read_xyz in mne/channels/_standard_montage_utils.py at the linked location, along with the surrounding montage-loading logic. Determine how fiducial names such as nasion, nz, lpa, and rpa are represented in ch_pos, and clarify the expected behavior for custom CSV montages; done means the intended fiducial coordinates are consistently passed to make_dig_montage.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100