mne-tools / mne-tools/mne-python
ENH : Building a test for checking the ylims in plot_evoked_topo
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3.5k
- Forks
- 1.6k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 100
Description
As discussed in PR https://github.com/mne-tools/mne-python/pull/9207#issuecomment-815302885, We need a test to check the ylims used for the individual subplots for plot_evoked_topo. This would identify and prevent any further issues arising with ylims in the future from newer versions of python.
Since the plot_evoked_topo has unified=true https://github.com/mne-tools/mne-python/pull/9207#issuecomment-814725032, It looks like it might not be possible to unpack the figure/axes object to access the individual ylims directly.
One idea that I had proposed earlier to @jasmainak was to build a debug parameter into plot_evoked_topo to be able to access all the individual parameters for the purpose of running tests before the creation of the figure object. Thoughts @larsoner @agramfort @drammock?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the plot_evoked_topo entry point and read the discussion in PR #9207, especially the comments about unified=True and accessing figure or axes objects. Review the existing plot tests, then define a test that checks the individual subplot ylims; done means future Python-version changes cannot alter those limits unnoticed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data-visualization, testing
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100