mne-tools / mne-tools/mne-python
Parsing dates in NIRx file for non-english locales fails
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3.5k
- Forks
- 1.6k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 100
Description
Describe the bug
Parsing dates in NIRx files does not work reliably for non English files.
Steps to reproduce
See #7891 and test test_encoding() in test_nirx.py.
Expected results
Date should be read correctly.
Actual results
Currently reading of date fails and the date is set to Jan 1st 2000
Additional information
To address this issue we need to know the date format for non English files. If non standard month naming is used (French) we need to know the non standard names used. If someone encounters this issue, it would be good to contact the vendor too.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with test_encoding() in test_nirx.py and review the related context in issue #7891. Reproduce the failure with a non-English NIRx file and determine the date format and month names used. Done means dates are read correctly instead of becoming Jan 1st 2000, with coverage for the affected locale.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100