mne-tools / mne-tools/mne-python
ENH: When using `set_montage` additional channels as extra points
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3.5k
- Forks
- 1.6k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 100
Description
It might be better if we make it so that doing inst.set_montage, rather than discarding EEG channels that aren't in the instance, instead added them to info['dig'] as extra / headshape points. It should help with coreg, and make it so that we get consistent sphere fits any time the same montage is used. It would allow us to update the sphere argument of our topomap plotting functions to allow looking for EEG+extra dig points to enable 'auto' fit-based mode.
After #7455 is in, I might try a quick PR to see how this affects the topomaps.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the set_montage behavior around channels absent from the instance, then inspect the topomap plotting functions' sphere argument and the changes from #7455. Determine how extra dig points should be represented in info['dig'] and how coregistration and sphere fitting should use them. Done means the behavior and fit-based plotting proposal are defined and covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend, data-visualization
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 28/100