mne-tools / mne-tools/mne-python
create_eog_epochs does not detect the maximum signal during blink events
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3.5k
- Forks
- 1.6k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 100
Description
Hi,
using the mne.preprocessing.create_eog_epochs() function does result in weird solutions. The epochs center is not the center of the peak. I would guess it has something to do with the filtering during blink detection. What is your opinion?
Average EOG plotting channels Fp1 and Fp1
EOG epochs plotting channels Fp1 and Fp2
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue centers on mne.preprocessing.create_eog_epochs(); start by reproducing the reported blink alignment using the attached EOG plots and examining the function's filtering and event-centering behavior. Clarify the intended peak-detection behavior before changing anything; done means epochs are centered on the maximum blink signal rather than being visibly offset.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100