mne-tools / mne-tools/mne-python

FIX: Improve covariance code

Open
#4,676 1 comment 0 reactions 2 assignees View on GitHub

@dengemann is already working on this.

Since Nov 6, 2018.

BUG ENH
Dominant language
Python
Stars
3.5k
Forks
1.6k
Avg merge
1d 6h
Merged PRs (30d)
100

Description

Ideas from previous discussions:

  • Unify handling of rank between mne/cov.py and mne/viz/evoked.py:plot_evoked_white (esp. mag / grad parameters) (#4799)
  • Low rank computation to speed up fitting (esp. for SSS data), adapt from unused bits of #4637 (#5481)
  • Have maxwell_filter with movecomp set the n_components in sss_info to the proportion of time a given MPM was used. (Currently it's binary, and it only uses the destination position.)
  • Have maxwell_filter set nfree based on the effective/estimated rank of the raw data, or from thresholding the float n_components?
  • Improve rank estimation code to deal with movement compensated data (which has time-varying rank) and also ICA (which can reduce rank but isn't stored in info)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.