mne-tools / mne-tools/mne-python
Update handling of projectors in FIF I/O
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3.5k
- Forks
- 1.6k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 100
Description
We are missing a new field, looking at a mne compare_fiff between a newly acquired file and our I/O round-trip of it:
We also write ACTIVE when we probably shouldn't. We should allow this to be 0, 1, or None.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the reported mne compare_fiff difference between the newly acquired file and the I/O round-trip, then trace the FIF projector read and write paths. Identify the missing field and verify that ACTIVE is handled with the allowed values 0, 1, or None; the comparison should show no unintended projector-field differences when done.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100