Filtering enforces double precision

Open
#13,738 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
data

Research direction

Start at filtering.py > _check_filterable and read the surrounding filtering pipeline. Resolve whether lower-precision inputs can be supported safely, and establish the expected behavior and computational rationale before implementation.

Written by the indexing model from the issue text.

Description

Hi, the filtering pipeline strictly enforces double-precision (filtering.py >_check_filterable).

When dealing with long recordings at high sampling rates, people often reduce precision to suit their storage and computational needs. I feel enforcing this datatype might be an overkill. Was there a specific computational reason for this?

Dominant language
Python
Stars
3.5k
Forks
1.6k
Avg merge
1d 6h
Merged PRs (30d)
100

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mne-tools/mne-python

All issues in mne-tools/mne-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.