mne-tools / mne-tools/mne-python

support drop_channels method in DigMontage

Open
#13,386 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
3.5k
Forks
1.6k
Avg merge
1d 6h
Merged PRs (30d)
100

Description

I would like to add a remove_channels method to

https://mne.tools/dev/generated/mne.channels.DigMontage.html#mne.channels.DigMontage

Could this be as simple as adjusting the remove_fiducials method?

https://github.com/mne-tools/mne-python/blob/ace9381898b3ad9da9590a3d0b99abedaa74e033/mne/channels/montage.py#L677-L702

The reason I need this is that I am working w ith an experimental montage, which I obtain by "tuning" an existing montage (renaming, dropping).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the DigMontage API and the remove_fiducials implementation in mne/channels/montage.py at lines 677-702. Determine the intended behavior and naming for removing montage channels, including the experimental rename-and-drop use case, then verify the public API reflects that behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend-api-design
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.