mne-tools / mne-tools/mne-python
BUG: LinearModel should use MetaEstimator
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3.5k
- Forks
- 1.6k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 100
Description
See https://github.com/scikit-learn/scikit-learn/issues/30237#issuecomment-2465572885, our __getattr__ wrapping is a bit of an unreliable hack.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Start by locating LinearModel and reading its getattr wrapping, then review the linked scikit-learn discussion about MetaEstimator. Done means the unreliable wrapping is replaced with the intended MetaEstimator approach and the relevant LinearModel tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100