mne-tools / mne-tools/mne-python
Adding ability to get minimum and maximum peaks from evoked object
Open
Nobody has claimed this yet.
ENH
- Dominant language
- Python
- Stars
- 3.5k
- Forks
- 1.6k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 100
Description
Describe the new feature or enhancement
Adds the ability to find minimum and maximum peaks not just negative and positive.
Describe your proposed implementation
Append a simple conditional to the _get_peak() function.
Usage:
evoked.get_peak(mode="max")
Describe possible alternatives
N/A
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the _get_peak() function and the Evoked.get_peak() entry point, then inspect how the existing negative and positive modes are handled. Check nearby tests for peak selection behavior. Done means the Evoked object supports the proposed max mode and the relevant behavior is covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100