mne-tools / mne-tools/mne-python
Highlight bad Epochs instead of dropping them when preload=False upon plotting
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3.5k
- Forks
- 1.6k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 100
Description
Describe the new feature or enhancement
Hello! I am currently working on a feature to drop Epoch based on callables in #12195, and thought it would be a nice feature to be able to see which Epochs would be dropped (since you may have complicated callables) if preload=False in the Epochs constructor.
Describe your proposed implementation
I think this could be implemented by displaying the rejected epochs instead of dropping them when plotting. For instance:
epochs = mne.Epochs(
raw,
events,
tmin=-0.2,
tmax=0.5,
reject_tmax=0,
reject=reject_criteria,
flat=flat_criteria,
reject_by_annotation=False,
preload=False
)
epochs.plot()
Hypothetical output (Epochs in red will be dropped):
Describe possible alternatives
Maybe instead of this method. I can add another parameter, but I think this is too complicated.
Additional context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Epochs constructor and its plot entry point, then trace how reject and flat criteria are handled when preload=False. Done means plotting identifies the epochs that would be dropped instead of silently omitting them, while preserving the proposed example's behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data-visualization
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100