Once more: Traces of bad channels in PSD figures

Open
#12,159 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
5/5
Estimated time
Over a week
Newbie friendliness
25/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
data-visualization

Research direction

Start by reading issue #12142 and reviewing the current PSD plot and Report rendering for bad-channel traces. Compare possible visual treatments against the attached example; done means bad traces are reliably distinguishable from normal traces, including in blurred Report figures.

Written by the indexing model from the issue text.

Description

a11y VIZ

#12142 improved the discoverability of bad channels in PSD plots. However, I have to say I'm sometimes still struggling to really tell these traces apart from the non-bads; maybe it's the slightly blurred figures we add to Reports; maybe it's my display; maybe it's my eyes. Here's an example:

Screenshot 2023-11-01 at 11 22 01

I cannot really see that the line is dashed / pointed, unless I look super super closely. In fact, at first I panicked and re-analyzed that dataset over and over again, trying to find that one rogue channel, until I discovered it had already been marked as bad. I just didn't really see it.

Any ideas on how things could be further improved would be greatly appreciated!

Dominant language
Python
Stars
3.5k
Forks
1.6k
Avg merge
1d 6h
Merged PRs (30d)
100

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from mne-tools/mne-python

All issues in mne-tools/mne-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.