mne-tools / mne-tools/mne-python
Consider adding (correct) proportion of variance explained by ICA components to Report
Open
Nobody has claimed this yet.
API
needs-discussion
- Dominant language
- Python
- Stars
- 3.5k
- Forks
- 1.6k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 100
Description
We removed it because the calculation was incorrect. The correct approach may be too time-consuming, though
See https://github.com/mne-tools/mne-python/pull/12156#issuecomment-1787746407 for discussion
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or entry points. Start by reading the discussion on pull request #12156, especially the linked comment, to understand why the previous calculation was removed and what a correct approach requires. Done means the Report includes a validated proportion of variance explained by ICA components.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data-visualization, machine-learning
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100