mne-tools / mne-tools/mne-python
annotate_break() should ignore `New Segment` annotations by default
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3.5k
- Forks
- 1.6k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 100
Description
Describe the new feature or enhancement
Currently, annotate_break() ignores annotations starting with bad and edge.
I'm working with BrainVision data, and each recording run starts with a New Segment annotation that is added by the acquisition system and is not an experimental event. It should be added to the list of annotations that is ignored when calculating break durations in annotate_break().
Describe your proposed implementation
Add New Segment annotations to list of ignored annotations in annotate_break().
Describe possible alternatives
–
Additional context
–
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Python implementation and existing tests for annotate_break(). Review how annotations beginning with bad and edge are ignored when calculating break durations. Done means New Segment annotations are ignored by default without changing the existing behavior for other annotations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100