mne-tools / mne-tools/mne-python

make _unit2human public

Open
#11,854 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
3.5k
Forks
1.6k
Avg merge
1d 6h
Merged PRs (30d)
100

Description

pybv relies on mne.channels.channels._unit2human, which in #11839 is moving to mne.io.meas_info. For now we'll import it back into mne.channels.channels so the tests will still pass and pybv will still work; but in the long term we should

  1. make it public, and
  2. change pybv to import it from wherever its new public exposure point is

cc @sappelhoff

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the _unit2human move described in #11839 and the current locations mne.channels.channels and mne.io.meas_info. Identify the intended public exposure point, update pybv to import from it, and verify that the existing tests still pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.