mne-tools / mne-tools/mne-python
Dc_offset in non-electrophysiology channels
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 3.5k
- Forks
- 1.6k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 100
Description
This came up in the discourse channel regarding Eyetracking channels, but could be relevant to any non electrophysiology channels.
The question being: should remove_dc only apply to electrophysiology channels?
I think the general feeling is yes? If so, does remove_dc serve a double purpose of mean centering traces on the plot, and will removing it cause traces for some data to go beyond the current y-axis scalings?
Cc @mscheltienne @britta-wstnr @sappelhoff
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked Discourse discussion about eyetracking traces and review how remove_dc affects non-electrophysiology channels in the plotting workflow. Determine whether mean centering should be limited to electrophysiology channels and verify whether changing it would make traces exceed current y-axis scalings; done means the behavior and scaling implications are resolved and documented by tests or an agreed decision.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data-visualization
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100