mne-tools / mne-tools/mne-python

Allow Epochs reject and flat params to be callables

Open
#11,775 4 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

ENH sprint-2023
Dominant language
Python
Stars
3.5k
Forks
1.6k
Avg merge
1d 6h
Merged PRs (30d)
100

Description

The main use case is to do channel rejection based on standard deviations or absolute peak values (not peak-to-peak values, which is what we do currently)

This has come up a few times, e.g. here:
https://mne.discourse.group/t/epoch-rejection-according-to-deviation-from-mean/2980

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Epochs rejection implementation and the handling of flat parameters in the repository. Review the linked discussion for the intended callable behavior and existing rejection tests; done means callable rejection and flat-parameter inputs support the stated use cases without breaking current behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.