mne-tools / mne-tools/mne-python
make_inverse_operator() should warn upon mismatch between "info" and empirical "noise_cov" rank
Open
Nobody has claimed this yet.
ENH
- Dominant language
- Python
- Stars
- 3.5k
- Forks
- 1.6k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 100
Description
As per discussion on Discord w/ @agramfort, @larsoner, @britta-wstnr, @alexrockhill
Also x-ref #4676
cc @SophieHerbst
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the make_inverse_operator() entry point and trace how info rank is compared with the empirical noise_cov rank. Review the discussion and cross-reference #4676 for the intended behavior. Done means a warning is emitted when the ranks mismatch, with coverage for the relevant case.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100