mne-tools / mne-tools/mne-python

MAINT: Replace our internal STFT with scipy.signal.stft

Open
#10,445 3 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

MAINT MEDIUM
Dominant language
Python
Stars
3.5k
Forks
1.6k
Avg merge
1d 6h
Merged PRs (30d)
100

Description

Once https://github.com/scipy/scipy/pull/15704 is merged we should ideally be able to directly call STFT and preserve power. However, that would require waiting ~2 years. Instead I think we should add a version to fixes.py where the appropriate scale factors from https://github.com/scipy/scipy/pull/15704 are used to preserve power.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.