mne-tools / mne-tools/mne-python
mne.viz.Brain.add_volume_labels( )
Open
Nobody has claimed this yet.
BUG
- Dominant language
- Python
- Stars
- 3.5k
- Forks
- 1.6k
- Avg merge
- 1d 6h
- Merged PRs (30d)
- 100
Description
Describe the bug
The function add_volume_labels() can not be added dictionary legend.
The bug is in the line 2525
_validate_type(legend, (bool, None), 'legend')
which should be changed to
_validate_type(legend, (bool, None, dict), 'legend')
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at mne.viz.Brain.add_volume_labels() and inspect line 2525, where legend is validated. Confirm the intended dictionary input and check the relevant existing test coverage; done means dictionary legends are accepted without a validation failure.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data-visualization
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100